[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162842712 --- Diff: sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarBatch.java --- @@ -96,16 +90,6 @@ public void setNumRows(int numRows) {

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162753323 --- Diff: sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarBatch.java --- @@ -96,16 +90,6 @@ public void setNumRows(int numRows) { */

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20316 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162522356 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java --- @@ -50,6 +50,9 @@ *

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162520627 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java --- @@ -50,6 +50,9 @@ *

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162520019 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java --- @@ -50,6 +50,9 @@ *

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162519101 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java --- @@ -49,18 +49,8 @@ * After

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162518569 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java --- @@ -50,6 +50,9 @@ *

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162518087 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java --- @@ -50,6 +50,9 @@ *

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162514432 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVectorUtils.java --- @@ -192,7 +192,7 @@ private static void

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162489756 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowEvalPythonExec.scala --- @@ -90,8 +90,9 @@ case class

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162477811 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java --- @@ -49,18 +49,8 @@ * After

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162487635 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java --- @@ -50,6 +50,9 @@ *

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162489186 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java --- @@ -98,22 +88,22 @@ public

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162413046 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVectorUtils.java --- @@ -192,7 +192,7 @@ private static void

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/20316 [SPARK-23149][SQL] polish ColumnarBatch ## What changes were proposed in this pull request? Several cleanups in `ColumnarBatch` * remove `schema`. The `ColumnVector`s inside