Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20333
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20333#discussion_r162807813
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala ---
@@ -274,4 +274,18 @@ class DataFrameJoinSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20333#discussion_r162794983
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala ---
@@ -274,4 +274,18 @@ class DataFrameJoinSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20333#discussion_r162794939
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1108,15 +1108,19 @@ object CheckCartesianProducts
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20333#discussion_r162793942
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1108,15 +1108,19 @@ object CheckCartesianProducts
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20333#discussion_r162759088
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1108,15 +1108,19 @@ object CheckCartesianProducts
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20333#discussion_r162758553
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala ---
@@ -274,4 +274,18 @@ class DataFrameJoinSuite extends QueryTest with
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/20333
[SPARK-23087][SQL] CheckCartesianProduct too restrictive when condition is
false/null
## What changes were proposed in this pull request?
CheckCartesianProduct raises an
