Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r164551253
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -251,10 +251,8 @@ private[hive] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r164050130
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -251,10 +251,8 @@ private[hive] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r164043733
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -251,10 +251,8 @@ private[hive] class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r164043569
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -251,10 +251,8 @@ private[hive] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r164035915
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -251,10 +251,8 @@ private[hive] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r164032685
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -251,10 +251,8 @@ private[hive] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r163938641
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -251,10 +251,8 @@ private[hive] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r163936822
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -251,10 +251,8 @@ private[hive] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r163936367
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -251,10 +251,8 @@ private[hive] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r163920410
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -251,10 +251,8 @@ private[hive] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r163774967
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -251,10 +251,8 @@ private[hive] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r163774842
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
---
@@ -251,10 +251,8 @@ private[hive] class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r163655221
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -132,7 +131,8 @@ private[hive] class HiveClientImpl(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r163631446
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -132,7 +131,8 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r163630721
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -132,7 +131,8 @@ private[hive] class HiveClientImpl(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r163628671
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -132,7 +131,8 @@ private[hive] class HiveClientImpl(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r163627927
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -132,7 +131,8 @@ private[hive] class HiveClientImpl(
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20377#discussion_r163627455
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -132,7 +131,8 @@ private[hive] class HiveClientImpl(
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/20377
[SPARK-17088] [FOLLOW-UP] Fix 'sharesHadoopClasses' option when creating
client
## What changes were proposed in this pull request?
This PR is to remove useless `warehouseDir`, which is
19 matches
Mail list logo