Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20382
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r171954250
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
---
@@ -0,0 +1,300 @@
+/*
+ * Licensed
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r171511528
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
---
@@ -0,0 +1,300 @@
+/*
+ *
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r171510614
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
---
@@ -0,0 +1,300 @@
+/*
+ * Licensed
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r171506698
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
---
@@ -0,0 +1,300 @@
+/*
+ *
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r171469866
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
---
@@ -0,0 +1,300 @@
+/*
+ *
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r171226477
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/socket.scala
---
@@ -61,13 +68,13 @@ class TextSocketSource(host: String,
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r171225853
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
---
@@ -0,0 +1,300 @@
+/*
+ * Licensed
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r171225732
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
---
@@ -0,0 +1,300 @@
+/*
+ * Licensed
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r170759995
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
---
@@ -0,0 +1,246 @@
+/*
+ * Licensed
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r170178735
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
---
@@ -0,0 +1,246 @@
+/*
+ *
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r168363424
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -583,7 +585,8 @@ object DataSource extends Logging {
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r168138470
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
---
@@ -0,0 +1,246 @@
+/*
+ * Licensed
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r168137288
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
---
@@ -0,0 +1,246 @@
+/*
+ * Licensed
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r167776323
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
---
@@ -0,0 +1,246 @@
+/*
--- End
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r167713045
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/socket.scala
---
@@ -15,40 +15,48 @@
* limitations under the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r167126569
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/socket.scala
---
@@ -15,40 +15,48 @@
* limitations under the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r167128485
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/socket.scala
---
@@ -164,54 +213,43 @@ class TextSocketSource(host:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r167126475
--- Diff:
sql/core/src/main/resources/META-INF/services/org.apache.spark.sql.sources.DataSourceRegister
---
@@ -5,6 +5,6 @@
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r167127039
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/socket.scala
---
@@ -103,23 +111,40 @@ class TextSocketSource(host:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r167128652
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -177,11 +177,14 @@ final class DataStreamReader
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r167128044
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/socket.scala
---
@@ -164,54 +213,43 @@ class TextSocketSource(host:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r167128861
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSuite.scala
---
@@ -0,0 +1,246 @@
+/*
--- End diff
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r167128691
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
---
@@ -177,11 +177,14 @@ final class DataStreamReader
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r167127081
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/socket.scala
---
@@ -103,23 +111,40 @@ class TextSocketSource(host:
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r167126686
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/socket.scala
---
@@ -15,40 +15,48 @@
* limitations under the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r164944650
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala
---
@@ -47,130 +48,141 @@ object TextSocketSource {
* This
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r164944362
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TextSocketReader.scala
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r164944324
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala
---
@@ -47,130 +48,141 @@ object TextSocketSource {
* This
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r164944276
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala
---
@@ -47,130 +48,141 @@ object TextSocketSource {
* This
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r164943885
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala
---
@@ -47,130 +48,141 @@ object TextSocketSource {
*
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r164937540
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala
---
@@ -47,130 +48,141 @@ object TextSocketSource {
* This
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r164934753
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ConsoleWriter.scala
---
@@ -56,7 +58,7 @@ trait ConsoleWriter extends
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r164933597
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala
---
@@ -47,130 +48,141 @@ object TextSocketSource {
* This
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r164930581
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/socket.scala
---
@@ -47,130 +48,141 @@ object TextSocketSource {
* This
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r164930523
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ConsoleWriter.scala
---
@@ -56,7 +58,7 @@ trait ConsoleWriter extends
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r163755819
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSourceV2.scala
---
@@ -0,0 +1,247 @@
+/*
+ *
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r163755636
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSourceV2.scala
---
@@ -0,0 +1,247 @@
+/*
+
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r163753088
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSourceV2.scala
---
@@ -0,0 +1,247 @@
+/*
+ *
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r163730153
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSourceV2.scala
---
@@ -0,0 +1,247 @@
+/*
+
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r163725096
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSourceV2.scala
---
@@ -0,0 +1,247 @@
+/*
+ *
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r163614088
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSourceV2.scala
---
@@ -0,0 +1,247 @@
+/*
+
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r163613655
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSourceV2.scala
---
@@ -0,0 +1,247 @@
+/*
+
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r163616762
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSourceV2.scala
---
@@ -0,0 +1,247 @@
+/*
+
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r163612181
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketStreamSourceV2.scala
---
@@ -0,0 +1,247 @@
+/*
+
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20382#discussion_r163487603
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ConsoleWriter.scala
---
@@ -56,7 +58,7 @@ trait ConsoleWriter extends
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/20382
[SPARK-23097][SQL][SS] Migrate text socket source to V2
## What changes were proposed in this pull request?
This PR moves structured streaming text socket source to V2.
47 matches
Mail list logo
