Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r164249345
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -450,13 +439,11 @@ final boolean isNullAt(int rowId) {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20395
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r164160869
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchBenchmark.scala
---
@@ -479,10 +475,10 @@ object
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r164088592
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java
---
@@ -602,7 +603,17 @@ public final int
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r164086846
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -182,57 +187,54 @@
}
/**
- * Returns
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r164086579
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -450,13 +437,12 @@ final boolean isNullAt(int rowId) {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r164086245
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java
---
@@ -602,7 +603,17 @@ public final int
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r164067505
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java
---
@@ -602,7 +603,17 @@ public final int
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r164066651
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -450,13 +437,12 @@ final boolean isNullAt(int rowId) {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r164065557
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -182,57 +187,54 @@
}
/**
- * Returns the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r164049147
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -433,10 +418,14 @@ final long getLong(int rowId) {
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r164047732
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -433,10 +418,14 @@ final long getLong(int rowId) {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r164030712
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -450,13 +439,11 @@ final boolean isNullAt(int rowId) {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r164030610
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchBenchmark.scala
---
@@ -479,10 +475,10 @@ object
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r163965864
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchBenchmark.scala
---
@@ -479,10 +475,10 @@ object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20395#discussion_r163915680
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -450,13 +439,11 @@ final boolean isNullAt(int rowId) {
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/20395
[SPARK-23218][SQL] simplify ColumnVector.getArray
## What changes were proposed in this pull request?
`ColumnVector` is very flexible about how to implement array type. As a
result
17 matches
Mail list logo
