Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r167393259
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamSourceV2.scala
---
@@ -139,15 +139,15 @@ class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r167392663
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/RateSourceV2Suite.scala
---
@@ -78,7 +78,7 @@ class RateSourceV2Suite
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20397
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164425992
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataReaderFactory.java
---
@@ -22,21 +22,23 @@
import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164425827
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataReaderFactory.java
---
@@ -22,21 +22,23 @@
import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164425194
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/SupportsScanColumnarBatch.java
---
@@ -30,21 +30,21 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164349078
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/Distribution.java
---
@@ -21,9 +21,9 @@
/**
* An interface to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164349108
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/Distribution.java
---
@@ -21,9 +21,9 @@
/**
* An interface to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164348810
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataSourceV2Reader.java
---
@@ -63,7 +63,7 @@
StructType readSchema();
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164348145
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataSourceV2Reader.java
---
@@ -63,7 +63,7 @@
StructType readSchema();
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164348008
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataReaderFactory.java
---
@@ -50,7 +50,7 @@
}
/**
- *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164347780
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataReaderFactory.java
---
@@ -22,19 +22,19 @@
import
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164347650
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/SupportsScanColumnarBatch.java
---
@@ -30,21 +30,21 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164347542
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ClusteredDistribution.java
---
@@ -22,7 +22,7 @@
/**
* A concrete
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164345010
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/SupportsScanColumnarBatch.java
---
@@ -30,21 +30,21 @@
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164342995
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/SupportsScanColumnarBatch.java
---
@@ -30,21 +30,21 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164335994
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/SupportsScanColumnarBatch.java
---
@@ -30,21 +30,21 @@
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r164248501
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/SupportsScanColumnarBatch.java
---
@@ -30,21 +30,21 @@
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r163921087
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala
---
@@ -22,24 +22,24 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20397#discussion_r163920956
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousDataSourceRDDIter.scala
---
@@ -39,14 +39,14 @@ import
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/20397
[SPARK-23219][SQL]Rename ReadTask to DataReaderFactory in data source v2
## What changes were proposed in this pull request?
Currently we have `ReadTask` in data source v2 reader,
21 matches
Mail list logo
