[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r175339309 --- Diff: sql/core/src/test/resources/sql-tests/results/interval.sql.out --- @@ -0,0 +1,375 @@ +-- Automatically generated by SQLQueryTestSuite

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r175336924 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala --- @@ -155,6 +155,7 @@ class QueryExecution(val sparkSession:

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r175336329 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala --- @@ -155,6 +155,7 @@ class QueryExecution(val sparkSession:

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-12 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r174016181 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -83,6 +83,15 @@ class SQLQueryTestSuite extends QueryTest with

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r174016110 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -83,6 +83,15 @@ class SQLQueryTestSuite extends QueryTest with

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-12 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r174011447 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala --- @@ -83,6 +83,15 @@ class SQLQueryTestSuite extends QueryTest with

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r172427740 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -790,6 +796,16 @@ ASC: 'ASC'; DESC: 'DESC'; FOR:

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r172427617 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -790,6 +796,16 @@ ASC: 'ASC'; DESC: 'DESC'; FOR:

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-05 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r172427354 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -790,6 +796,16 @@ ASC: 'ASC'; DESC: 'DESC'; FOR:

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r172426790 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -790,6 +796,16 @@ ASC: 'ASC'; DESC: 'DESC'; FOR:

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r172426643 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -790,6 +796,16 @@ ASC: 'ASC'; DESC: 'DESC'; FOR:

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-01-31 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r165259575 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala --- @@ -561,8 +561,11 @@ class ExpressionParserSuite

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-01-31 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r165233944 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala --- @@ -561,8 +561,11 @@ class

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-01-29 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/20433 [SPARK-23264][SQL] Support interval values without INTERVAL clauses ## What changes were proposed in this pull request? This pr updated parsing rules in `SqlBase.g4` to support a SQL query