Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20518
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20518#discussion_r167427660
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -745,4 +763,27 @@ private[spark] class CosineDistanceMeasure extends
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/20518#discussion_r167417459
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -745,4 +763,27 @@ private[spark] class CosineDistanceMeasure
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20518#discussion_r166884184
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -745,4 +763,27 @@ private[spark] class CosineDistanceMeasure extends
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/20518#discussion_r166813909
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -745,4 +763,27 @@ private[spark] class CosineDistanceMeasure
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20518#discussion_r166780413
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -745,4 +763,27 @@ private[spark] class CosineDistanceMeasure extends
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20518#discussion_r166338499
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -745,4 +763,27 @@ private[spark] class CosineDistanceMeasure extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20518#discussion_r166336855
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -745,4 +763,27 @@ private[spark] class CosineDistanceMeasure extends
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/20518
[SPARK-22119][FOLLOWUP][ML] Use spherical KMeans with cosine distance
## What changes were proposed in this pull request?
In #19340 some comments considered needed to use spherical KMeans
