Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20535#discussion_r183580907
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -193,10 +196,13 @@ class DataFrameReader private[sql](sparkSession:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20535#discussion_r183470867
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -193,10 +196,13 @@ class DataFrameReader private[sql](sparkSession:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20535
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20535#discussion_r180714763
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceOptions.java
---
@@ -17,16 +17,61 @@
package
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20535#discussion_r180171421
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceOptions.java
---
@@ -97,4 +142,66 @@ public double getDouble(String key,
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20535#discussion_r169708283
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -190,10 +190,15 @@ class DataFrameReader private[sql](sparkSession:
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20535#discussion_r169707938
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceOptions.java
---
@@ -97,4 +130,20 @@ public double getDouble(String key, double
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20535#discussion_r169707644
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceOptions.java
---
@@ -27,6 +27,39 @@
/**
* An immutable
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20535#discussion_r166826237
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -171,7 +171,8 @@ class DataFrameReader private[sql](sparkSession:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20535#discussion_r166826138
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceOptions.java
---
@@ -27,6 +27,39 @@
/**
* An immutable
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20535#discussion_r166709990
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -171,7 +171,8 @@ class DataFrameReader private[sql](sparkSession:
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20535#discussion_r166701501
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceOptions.java
---
@@ -27,6 +27,39 @@
/**
* An immutable string-to-string
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/20535
[SPARK-23341][SQL] define some standard options for data source v2
## What changes were proposed in this pull request?
Each data source implementation can define its own options and
13 matches
Mail list logo
