Github user rekhajoshm closed the pull request at:
https://github.com/apache/spark/pull/20556
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20556#discussion_r205862690
--- Diff: dev/lint-python ---
@@ -82,6 +87,34 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# Check python document style, skip check if
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20556#discussion_r205862781
--- Diff: dev/lint-python ---
@@ -82,6 +88,34 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# Check python document style, skip check if
Github user rekhajoshm commented on a diff in the pull request:
https://github.com/apache/spark/pull/20556#discussion_r170792111
--- Diff: dev/lint-python ---
@@ -82,6 +87,34 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# Check python document style, skip check
Github user rekhajoshm commented on a diff in the pull request:
https://github.com/apache/spark/pull/20556#discussion_r170792037
--- Diff: dev/tox.ini ---
@@ -17,3 +17,5 @@
ignore=E402,E731,E241,W503,E226,E722,E741,E305
max-line-length=100
Github user rekhajoshm commented on a diff in the pull request:
https://github.com/apache/spark/pull/20556#discussion_r170792051
--- Diff: dev/lint-python ---
@@ -82,6 +87,34 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# Check python document style, skip check
Github user rekhajoshm commented on a diff in the pull request:
https://github.com/apache/spark/pull/20556#discussion_r170792029
--- Diff: dev/lint-python ---
@@ -21,10 +21,15 @@ SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
SPARK_ROOT_DIR="$(dirname "$SCRIPT_DIR")"
#
Github user rekhajoshm commented on a diff in the pull request:
https://github.com/apache/spark/pull/20556#discussion_r170792015
--- Diff: dev/lint-python ---
@@ -21,10 +21,15 @@ SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
SPARK_ROOT_DIR="$(dirname "$SCRIPT_DIR")"
#
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/20556#discussion_r168263131
--- Diff: dev/lint-python ---
@@ -82,6 +87,34 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# Check python document style, skip
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/20556#discussion_r168263151
--- Diff: dev/lint-python ---
@@ -82,6 +87,34 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# Check python document style, skip
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20556#discussion_r168079061
--- Diff: dev/tox.ini ---
@@ -17,3 +17,5 @@
ignore=E402,E731,E241,W503,E226,E722,E741,E305
max-line-length=100
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20556#discussion_r168078916
--- Diff: dev/lint-python ---
@@ -21,10 +21,15 @@ SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
SPARK_ROOT_DIR="$(dirname "$SCRIPT_DIR")"
#
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20556#discussion_r168078994
--- Diff: dev/lint-python ---
@@ -21,10 +21,15 @@ SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
SPARK_ROOT_DIR="$(dirname "$SCRIPT_DIR")"
#
GitHub user rekhajoshm opened a pull request:
https://github.com/apache/spark/pull/20556
[SPARK-23367][Build] Include python document style checking
## What changes were proposed in this pull request?
Include python document style checking.
This PR includes the pydocstyle
14 matches
Mail list logo
