Github user mrkm4ntr closed the pull request at:
https://github.com/apache/spark/pull/20568
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20568#discussion_r168870192
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -218,4 +221,32 @@ object FeatureHasher extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20568#discussion_r168698344
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -218,4 +221,32 @@ object FeatureHasher extends
Github user mrkm4ntr commented on a diff in the pull request:
https://github.com/apache/spark/pull/20568#discussion_r168659153
--- Diff:
common/sketch/src/main/java/org/apache/spark/util/sketch/Murmur3_x86_32.java ---
@@ -71,6 +73,20 @@ public static int hashUnsafeBytes(Object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20568#discussion_r168415065
--- Diff:
common/sketch/src/main/java/org/apache/spark/util/sketch/Murmur3_x86_32.java ---
@@ -71,6 +73,20 @@ public static int hashUnsafeBytes(Object
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20568#discussion_r167419965
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/hash/Murmur3_x86_32Suite.java
---
@@ -51,6 +51,22 @@ public void testKnownLongInputs() {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20568#discussion_r167419960
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/hash/Murmur3_x86_32Suite.java
---
@@ -51,6 +51,22 @@ public void testKnownLongInputs() {
GitHub user mrkm4ntr opened a pull request:
https://github.com/apache/spark/pull/20568
[SPARK-23381][CORE] Murmur3 hash generates a different value from other
implementations
## What changes were proposed in this pull request?
Murmur3 hash generates a different value from the
