[GitHub] spark pull request #20626: [SPARK-23447][SQL] Cleanup codegen template for L...

2018-02-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20626 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20626: [SPARK-23447][SQL] Cleanup codegen template for L...

2018-02-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20626#discussion_r168909963 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -278,40 +278,45 @@ case class Literal (value: Any,

[GitHub] spark pull request #20626: [SPARK-23447][SQL] Cleanup codegen template for L...

2018-02-15 Thread rednaxelafx
GitHub user rednaxelafx opened a pull request: https://github.com/apache/spark/pull/20626 [SPARK-23447][SQL] Cleanup codegen template for Literal ## What changes were proposed in this pull request? Cleaned up the codegen templates for `Literal`s, to make sure that the