[GitHub] spark pull request #20689: [SPARK-23533][SS] Add support for changing Contin...

2018-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20689 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20689: [SPARK-23533][SS] Add support for changing Contin...

2018-03-14 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/20689#discussion_r174667490 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReader.scala --- @@ -164,7 +164,15 @@ case class

[GitHub] spark pull request #20689: [SPARK-23533][SS] Add support for changing Contin...

2018-03-14 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20689#discussion_r174585423 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReader.scala --- @@ -164,7 +164,15 @@ case class

[GitHub] spark pull request #20689: [SPARK-23533][SS] Add support for changing Contin...

2018-03-14 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20689#discussion_r174585821 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousRateStreamSource.scala --- @@ -106,7 +106,19 @@ case class

[GitHub] spark pull request #20689: [SPARK-23533][SS] Add support for changing Contin...

2018-03-14 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20689#discussion_r174585843 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ContinuousDataReaderFactory.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to

[GitHub] spark pull request #20689: [SPARK-23533][SS] Add support for changing Contin...

2018-02-28 Thread jose-torres
Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/20689#discussion_r171332700 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ContinuousDataReaderFactory.java --- @@ -0,0 +1,38 @@ +/* + * Licensed

[GitHub] spark pull request #20689: [SPARK-23533][SS] Add support for changing Contin...

2018-02-27 Thread xuanyuanking
GitHub user xuanyuanking opened a pull request: https://github.com/apache/spark/pull/20689 [SPARK-23533][SS] Add support for changing ContinuousDataReader's startOffset ## What changes were proposed in this pull request? As discussion in #20675, we need add a new interface