[GitHub] spark pull request #20779: [SPARK-23598][SQL] Make methods in BufferedRowIte...

2018-03-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20779 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20779: [SPARK-23598][SQL] Make methods in BufferedRowIte...

2018-03-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20779#discussion_r174046867 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -65,7 +65,7 @@ public long durationMs() { /**

[GitHub] spark pull request #20779: [SPARK-23598][SQL] Make methods in BufferedRowIte...

2018-03-09 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20779#discussion_r173613316 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala --- @@ -307,4 +309,47 @@ class WholeStageCodegenSuite extends

[GitHub] spark pull request #20779: [SPARK-23598][SQL] Make methods in BufferedRowIte...

2018-03-09 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20779#discussion_r173494440 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala --- @@ -307,4 +309,47 @@ class WholeStageCodegenSuite

[GitHub] spark pull request #20779: [SPARK-23598][SQL] Make methods in BufferedRowIte...

2018-03-09 Thread dvogelbacher
Github user dvogelbacher commented on a diff in the pull request: https://github.com/apache/spark/pull/20779#discussion_r173484471 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala --- @@ -307,4 +309,47 @@ class WholeStageCodegenSuite

[GitHub] spark pull request #20779: [SPARK-23598][SQL] Make methods in BufferedRowIte...

2018-03-08 Thread kiszk
GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/20779 [SPARK-23598][SQL] Make methods in BufferedRowIterator public to avoid compilation for a large query ## What changes were proposed in this pull request? This PR fixes compilation error