[GitHub] spark pull request #20787: Documenting months_between direction

2018-03-20 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20787#discussion_r175985253 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1115,13 +1115,17 @@ case class

[GitHub] spark pull request #20787: Documenting months_between direction

2018-03-20 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20787#discussion_r175983804 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -881,10 +881,10 @@ object DateTimeUtils {

[GitHub] spark pull request #20787: Documenting months_between direction

2018-03-20 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20787#discussion_r175983334 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1115,13 +1115,17 @@ case class

[GitHub] spark pull request #20787: Documenting months_between direction

2018-03-20 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20787#discussion_r175982564 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1115,13 +1115,17 @@ case class

[GitHub] spark pull request #20787: Documenting months_between direction

2018-03-20 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20787#discussion_r175668391 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1115,13 +1115,18 @@ case class

[GitHub] spark pull request #20787: Documenting months_between direction

2018-03-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20787#discussion_r173619271 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2708,7 +2708,8 @@ object functions { def minute(e: Column): Column

[GitHub] spark pull request #20787: Documenting months_between direction

2018-03-09 Thread aditkumar
GitHub user aditkumar opened a pull request: https://github.com/apache/spark/pull/20787 Documenting months_between direction ## What changes were proposed in this pull request? It's useful to know what relationship between date1 and date2 result in a positive number. You