[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-04-04 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r179238708 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1072,8 +1072,17 @@ class SessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-04-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r178471847 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1072,8 +1072,17 @@ class SessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-04-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r178471822 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1072,8 +1072,17 @@ class SessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-04-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r178471806 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1072,8 +1072,17 @@ class SessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-27 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r177637334 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1072,8 +1072,17 @@ class SessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r177593883 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1072,8 +1072,17 @@ class SessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-27 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r177487877 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1072,8 +1072,17 @@ class SessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r177142415 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1072,8 +1072,17 @@ class SessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-21 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r176308524 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -175,6 +175,8 @@ private[sql] class HiveSessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-21 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r176299569 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -175,6 +175,8 @@ private[sql] class HiveSessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-21 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r176292845 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r176292180 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-21 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r176276263 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -175,6 +175,8 @@ private[sql] class HiveSessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-21 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r176249337 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1076,6 +1076,16 @@ class SessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-21 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r176249308 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -175,6 +175,8 @@ private[sql] class HiveSessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-21 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r176039540 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -175,6 +175,8 @@ private[sql] class HiveSessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-21 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r176039913 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1076,6 +1076,16 @@ class SessionCatalog(

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-16 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r175248943 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-16 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r175159061 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,24 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-16 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r175158413 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,24 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-16 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r175156300 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r175029024 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-16 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r175026674 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,24 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r175026010 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,24 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-16 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r175025479 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-16 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r175023480 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-16 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r175022409 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r17440 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-15 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r174998505 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-12 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r174019434 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-12 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r174017514 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r173997939 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r173997911 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,11 +1195,23 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-11 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r173692751 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,10 +1193,18 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-11 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r173662663 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,10 +1193,18 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r173660285 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,10 +1193,18 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20795#discussion_r173655309 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1192,10 +1193,18 @@ class Analyzer( * @see

[GitHub] spark pull request #20795: [SPARK-23486]cache the function name from the cat...

2018-03-10 Thread kevinyu98
GitHub user kevinyu98 opened a pull request: https://github.com/apache/spark/pull/20795 [SPARK-23486]cache the function name from the catalog for lookupFunctions ## What changes were proposed in this pull request? This PR will cache the function name from spark and external