Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/20824#discussion_r175050086
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala ---
@@ -145,15 +146,23 @@ object FileCommitProtocol {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20824#discussion_r174988745
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala ---
@@ -145,15 +146,23 @@ object FileCommitProtocol {
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/20824#discussion_r174829859
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala ---
@@ -145,15 +146,23 @@ object FileCommitProtocol {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20824#discussion_r174801694
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala ---
@@ -145,15 +146,23 @@ object FileCommitProtocol {
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/20824#discussion_r174740987
--- Diff:
core/src/test/scala/org/apache/spark/internal/io/FileCommitProtocolInstantiationSuite.scala
---
@@ -0,0 +1,146 @@
+/*
+ * Licensed