Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20837
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20837#discussion_r178905201
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -517,6 +517,9 @@ class LogisticRegression
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20837#discussion_r175564965
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -517,6 +517,9 @@ class LogisticRegression @Since("1.2.0")
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20837#discussion_r175563532
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -517,6 +517,9 @@ class LogisticRegression @Since("1.2.0")
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20837#discussion_r174995768
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala ---
@@ -55,6 +55,11 @@ private[spark] class Instrumentation[E <:
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20837#discussion_r174995625
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala ---
@@ -55,6 +55,11 @@ private[spark] class Instrumentation[E <:
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20837#discussion_r174996170
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -517,6 +517,9 @@ class LogisticRegression
GitHub user MrBago opened a pull request:
https://github.com/apache/spark/pull/20837
[SPARK-23686][ML][WIP] Better instrumentation
## What changes were proposed in this pull request?
This PR is meant to show how we could better utilize the Instrumentation
class in
