[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-08-21 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r211688118 --- Diff: python/pyspark/streaming/tests.py --- @@ -206,6 +207,38 @@ def func(dstream): expected = [[len(x)] for x in input]

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-08-21 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r211688841 --- Diff: python/pyspark/streaming/tests.py --- @@ -206,6 +207,38 @@ def func(dstream): expected = [[len(x)] for x in input]

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-08-03 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r207604490 --- Diff: python/pyspark/streaming/tests.py --- @@ -206,6 +207,22 @@ def func(dstream): expected = [[len(x)] for x in input]

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-27 Thread cclauss
Github user cclauss commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r205933934 --- Diff: python/pyspark/streaming/tests.py --- @@ -206,6 +207,22 @@ def func(dstream): expected = [[len(x)] for x in input]

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-27 Thread cclauss
Github user cclauss commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r205870627 --- Diff: dev/create-release/releaseutils.py --- @@ -149,7 +152,11 @@ def get_commits(tag): if not is_valid_author(author):

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r204269682 --- Diff: python/pyspark/sql/conf.py --- @@ -59,7 +62,7 @@ def unset(self, key): def _checkType(self, obj, identifier):

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-20 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r204190696 --- Diff: dev/create-release/releaseutils.py --- @@ -149,7 +152,11 @@ def get_commits(tag): if not is_valid_author(author):

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-20 Thread cclauss
Github user cclauss commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r204094593 --- Diff: dev/create-release/releaseutils.py --- @@ -149,7 +152,11 @@ def get_commits(tag): if not is_valid_author(author):

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-20 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r204093418 --- Diff: python/pyspark/streaming/dstream.py --- @@ -23,6 +23,8 @@ if sys.version < "3": from itertools import imap as map, ifilter as

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-20 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r204091905 --- Diff: dev/create-release/releaseutils.py --- @@ -149,7 +152,11 @@ def get_commits(tag): if not is_valid_author(author):

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-03 Thread cclauss
Github user cclauss commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r199701965 --- Diff: dev/merge_spark_pr.py --- @@ -39,6 +39,9 @@ except ImportError: JIRA_IMPORTED = False +if sys.version_info[0] >= 3: +

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-03 Thread cclauss
Github user cclauss commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r199701953 --- Diff: python/pyspark/sql/conf.py --- @@ -59,7 +62,7 @@ def unset(self, key): def _checkType(self, obj, identifier):

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-03 Thread cclauss
Github user cclauss commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r199702001 --- Diff: dev/create-release/releaseutils.py --- @@ -49,6 +49,9 @@ print("Install using 'sudo pip install unidecode'") sys.exit(-1)

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-06-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r194292645 --- Diff: dev/merge_spark_pr.py --- @@ -39,6 +39,9 @@ except ImportError: JIRA_IMPORTED = False +if sys.version_info[0] >= 3:

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-06-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r194292662 --- Diff: dev/create-release/releaseutils.py --- @@ -49,6 +49,9 @@ print("Install using 'sudo pip install unidecode'") sys.exit(-1)

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-06-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r194292586 --- Diff: python/pyspark/sql/conf.py --- @@ -59,7 +62,7 @@ def unset(self, key): def _checkType(self, obj, identifier):

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-06-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r194292548 --- Diff: python/pyspark/streaming/dstream.py --- @@ -23,6 +23,8 @@ if sys.version < "3": from itertools import imap as map, ifilter

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-04-12 Thread cclauss
Github user cclauss commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r181192109 --- Diff: python/pyspark/cloudpickle.py --- @@ -802,9 +802,8 @@ def save_not_implemented(self, obj): self.save_reduce(_gen_not_implemented, ())

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-03-26 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r177176851 --- Diff: dev/create-release/releaseutils.py --- @@ -149,7 +152,11 @@ def get_commits(tag): if not is_valid_author(author):

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-03-24 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r176904365 --- Diff: python/pyspark/cloudpickle.py --- @@ -802,9 +802,8 @@ def save_not_implemented(self, obj): self.save_reduce(_gen_not_implemented,

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-03-16 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r175240674 --- Diff: dev/create-release/releaseutils.py --- @@ -149,7 +152,11 @@ def get_commits(tag): if not is_valid_author(author):

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-03-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r175000904 --- Diff: dev/create-release/releaseutils.py --- @@ -49,6 +49,11 @@ print("Install using 'sudo pip install unidecode'") sys.exit(-1)

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-03-15 Thread cclauss
Github user cclauss commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r175000559 --- Diff: dev/create-release/releaseutils.py --- @@ -49,6 +49,11 @@ print("Install using 'sudo pip install unidecode'") sys.exit(-1)

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-03-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r175000330 --- Diff: dev/create-release/releaseutils.py --- @@ -49,6 +49,11 @@ print("Install using 'sudo pip install unidecode'") sys.exit(-1)

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-03-15 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20838#discussion_r17582 --- Diff: dev/create-release/releaseutils.py --- @@ -49,6 +49,11 @@ print("Install using 'sudo pip install unidecode'") sys.exit(-1)

[GitHub] spark pull request #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-03-15 Thread cclauss
GitHub user cclauss opened a pull request: https://github.com/apache/spark/pull/20838 [SPARK-23698] Resolve undefined names in Python 3 ## What changes were proposed in this pull request? Fix issues arising from the fact that __file__, __long__, __raw_input()__,