[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-09-19 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r218917303 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -665,3 +667,219 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-09-19 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r218677837 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -665,3 +667,219 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20858 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-18 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r182357725 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +356,218 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r182350135 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +356,218 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r182349064 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -353,3 +356,218 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-16 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r181740076 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,231 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r181640349 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,231 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r181638570 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,231 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r181643397 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,231 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r181641673 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,231 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r181639154 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,231 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-13 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r181359247 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,231 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-13 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r181355000 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,231 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-09 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r180181355 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +290,191 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-03 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178759909 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3046,6 +3036,16 @@ object functions { ArrayContains(column.expr,

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-03 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178759108 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +289,152 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-03 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178753211 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -699,3 +699,88 @@ abstract class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178711505 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +289,152 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178710167 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -700,3 +700,88 @@ abstract class TernaryExpression

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178708207 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -699,3 +699,88 @@ abstract class TernaryExpression

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178701403 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -408,6 +407,7 @@ object FunctionRegistry {

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178700701 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +289,166 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178700550 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3046,6 +3036,16 @@ object functions { ArrayContains(column.expr,

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-03-27 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r177419513 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +289,152 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-03-27 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r177351705 --- Diff: python/pyspark/sql/functions.py --- @@ -1834,6 +1819,25 @@ def array_contains(col, value): return

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-03-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r177279540 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +289,152 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-03-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r177278880 --- Diff: python/pyspark/sql/functions.py --- @@ -1834,6 +1819,25 @@ def array_contains(col, value): return

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-03-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r177278671 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -699,3 +699,88 @@ abstract class