[GitHub] spark pull request #20860: [SPARK-23743][SQL] Changed a comparison logic fro...

2018-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20860 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20860: [SPARK-23743][SQL] Changed a comparison logic fro...

2018-03-23 Thread jongyoul
Github user jongyoul commented on a diff in the pull request: https://github.com/apache/spark/pull/20860#discussion_r176654007 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala --- @@ -179,7 +179,7 @@ private[hive] class

[GitHub] spark pull request #20860: [SPARK-23743][SQL] Changed a comparison logic fro...

2018-03-23 Thread jongyoul
Github user jongyoul commented on a diff in the pull request: https://github.com/apache/spark/pull/20860#discussion_r176652812 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala --- @@ -179,7 +179,7 @@ private[hive] class

[GitHub] spark pull request #20860: [SPARK-23743][SQL] Changed a comparison logic fro...

2018-03-23 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20860#discussion_r176646535 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala --- @@ -179,7 +179,7 @@ private[hive] class

[GitHub] spark pull request #20860: [SPARK-23743][SQL] Changed a comparison logic fro...

2018-03-19 Thread jongyoul
GitHub user jongyoul opened a pull request: https://github.com/apache/spark/pull/20860 [SPARK-23743][SQL] Changed a comparison logic from containing 'slf4j' to starting with 'org.slf4j' ## What changes were proposed in this pull request? isSharedClass returns if some classes