Github user 10110346 closed the pull request at:
https://github.com/apache/spark/pull/20862
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20862#discussion_r178688855
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -301,7 +301,10 @@ private class ReadableChannelFileRegion(source:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20862#discussion_r178626148
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -301,7 +301,10 @@ private class ReadableChannelFileRegion(source:
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20862#discussion_r17862
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -301,7 +301,10 @@ private class ReadableChannelFileRegion(source:
Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20862#discussion_r177993186
--- Diff: core/src/test/scala/org/apache/spark/storage/DiskStoreSuite.scala
---
@@ -197,7 +197,7 @@ class DiskStoreSuite extends SparkFunSuite {
Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20862#discussion_r177992858
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -301,7 +301,10 @@ private class ReadableChannelFileRegion(source:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20862#discussion_r177986789
--- Diff: core/src/test/scala/org/apache/spark/storage/DiskStoreSuite.scala
---
@@ -197,7 +197,7 @@ class DiskStoreSuite extends SparkFunSuite {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20862#discussion_r177986757
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -301,7 +301,10 @@ private class ReadableChannelFileRegion(source:
GitHub user 10110346 opened a pull request:
https://github.com/apache/spark/pull/20862
[SPARK-23744][CORE]Fix memory leak in ReadableChannelFileRegion
## What changes were proposed in this pull request?
In the class `ReadableChannelFileRegion`, the `buffer` is direct memory,
