[GitHub] spark pull request #20870: [SPARK-23760][SQL] CodegenContext.withSubExprElim...

2018-03-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20870 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20870: [SPARK-23760][SQL] CodegenContext.withSubExprElim...

2018-03-20 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/20870#discussion_r175986986 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -942,7 +940,7 @@ class