Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20951
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20951#discussion_r178651108
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ForeachSinkSuite.scala
---
@@ -141,7 +141,7 @@ class ForeachSinkSuite
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20951#discussion_r178648761
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ForeachSinkSuite.scala
---
@@ -141,7 +141,7 @@ class ForeachSinkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20951#discussion_r178648616
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ForeachSinkSuite.scala
---
@@ -131,7 +131,7 @@ class ForeachSinkSuite extends
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20951#discussion_r178648434
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/ForeachSinkSuite.scala
---
@@ -131,7 +131,7 @@ class ForeachSinkSuite extends
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20951#discussion_r178647263
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ForeachSink.scala
---
@@ -17,52 +17,81 @@
package
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20951#discussion_r178645775
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ForeachSink.scala
---
@@ -17,52 +17,81 @@
package
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20951#discussion_r178645279
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ForeachSink.scala
---
@@ -17,52 +17,81 @@
package
GitHub user jose-torres opened a pull request:
https://github.com/apache/spark/pull/20951
[SPARK-23099][SS] Migrate foreach sink to DataSourceV2
## What changes were proposed in this pull request?
Migrate foreach sink to DataSourceV2.
Since the previous attempt at
