[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

2018-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21010 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

2018-05-07 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r186606198 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -2108,35 +2133,57 @@ case class

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

2018-05-07 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r186606172 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -2108,35 +2133,57 @@ case class

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

2018-05-07 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r186607122 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala --- @@ -706,6 +706,30 @@ class

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

2018-05-02 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r185691812 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -2108,35 +2133,53 @@ case class

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

2018-05-02 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r185691861 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -2108,35 +2133,53 @@ case class

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r180313214 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -2108,35 +2132,52 @@ case class

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r180312765 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -2108,35 +2132,52 @@ case class

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r180312702 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -2108,35 +2132,52 @@ case class

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r180311991 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -2050,33 +2058,49 @@ case class

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21010#discussion_r180310931 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -2022,6 +2022,8 @@ case class Encode(value:

[GitHub] spark pull request #21010: [SPARK-23900][SQL] format_number support user spe...

2018-04-09 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/21010 [SPARK-23900][SQL] format_number support user specifed format as argument ## What changes were proposed in this pull request? `format_number` support user specifed format as argument. For