Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21189
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/21189#discussion_r185652723
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/MemorySinkSuite.scala
---
@@ -220,11 +220,11 @@ class MemorySinkSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21189#discussion_r185515489
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/MemorySinkSuite.scala
---
@@ -220,11 +220,11 @@ class MemorySinkSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21189#discussion_r185514873
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/SizeInBytesOnlyStatsPlanVisitor.scala
---
@@ -33,8
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/21189#discussion_r185167182
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/memoryV2.scala
---
@@ -178,7 +179,7 @@ class
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/21189#discussion_r185167132
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/MemorySinkSuite.scala
---
@@ -220,11 +220,11 @@ class MemorySinkSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21189#discussion_r185043356
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/SizeInBytesOnlyStatsPlanVisitor.scala
---
@@ -33,8
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21189#discussion_r185042726
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/MemorySinkSuite.scala
---
@@ -220,11 +220,11 @@ class MemorySinkSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21189#discussion_r185041473
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/memoryV2.scala
---
@@ -178,7 +179,7 @@ class
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21189
[SPARK-24117][SQL] Unified the getSizePerRow
## What changes were proposed in this pull request?
This pr unified the `getSizePerRow` because `getSizePerRow` is used in many
places. For
10 matches
Mail list logo