Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21240
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186663637
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/udtf_replicate_rows.sql ---
@@ -0,0 +1,41 @@
+CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186663298
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/udtf_replicate_rows.sql ---
@@ -0,0 +1,41 @@
+CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186662955
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,54 @@ case class Stack(children:
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186659654
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -702,6 +703,20 @@ object TypeCoercion {
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186291554
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,51 @@ case class Stack(children:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186279795
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,51 @@ case class Stack(children:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186279765
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -702,6 +703,20 @@ object TypeCoercion {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186279481
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,51 @@ case class Stack(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186279427
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -702,6 +703,20 @@ object TypeCoercion {
}
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186277072
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,51 @@ case class Stack(children:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186277065
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/udtf_replicate_rows.sql ---
@@ -0,0 +1,38 @@
+CREATE TEMPORARY VIEW tab1 AS SELECT * FROM
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186277062
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -702,6 +703,20 @@ object TypeCoercion {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186276709
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +222,51 @@ case class Stack(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186276453
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/udtf_replicate_rows.sql ---
@@ -0,0 +1,38 @@
+CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186276431
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -702,6 +703,20 @@ object TypeCoercion {
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186263952
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +223,51 @@ case class Stack(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186264379
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala ---
@@ -307,6 +307,37 @@ class GeneratorFunctionSuite extends QueryTest
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186263913
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -702,6 +703,21 @@ object TypeCoercion {
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186263929
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -26,6 +26,7 @@ import
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186264107
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +223,51 @@ case class Stack(children:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186264417
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -222,6 +223,51 @@ case class Stack(children:
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186258432
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -1353,6 +1353,31 @@ class TypeCoercionSuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21240#discussion_r186258401
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/GeneratorFunctionSuite.scala ---
@@ -307,6 +307,37 @@ class GeneratorFunctionSuite extends QueryTest
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/21240
[SPARK-21274][SQL] Add a new generator function replicate_rows to support
EXCEPT ALL and INTERSECT ALL
## What changes were proposed in this pull request?
Add a new UDTF replicate_rows.
25 matches
Mail list logo
