[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r195713474 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -138,3 +121,40 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r195706585 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2427,4 +2427,14 @@ class JsonSuite extends

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r195151361 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -94,32 +94,15 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r195145029 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -138,3 +121,40 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r194147472 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -138,3 +121,40 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r194123992 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -138,3 +121,40 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r194117346 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -138,3 +121,40 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r194119938 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2427,4 +2427,14 @@ class JsonSuite extends

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r192106493 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2313,25 +2314,6 @@ class JsonSuite extends

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r191831524 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2313,25 +2314,6 @@ class JsonSuite extends

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r187780271 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -138,3 +121,40 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r187769734 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -138,3 +121,40 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r186284065 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -137,3 +121,40 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r186283555 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -137,3 +121,40 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r186277493 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -137,3 +121,40 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21247#discussion_r186277050 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -137,3 +121,40 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #21247: [SPARK-24190] Separating JSONOptions for read

GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/21247 [SPARK-24190] Separating JSONOptions for read ## What changes were proposed in this pull request? Currently, restrictions in JSONOptions for `encoding` and `lineSep` are the same for read