Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21299
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r189204217
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala ---
@@ -90,13 +92,42 @@ object SQLExecution {
* thread
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r188828684
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala ---
@@ -90,13 +92,42 @@ object SQLExecution {
* thread from
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r188665161
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala ---
@@ -90,13 +92,42 @@ object SQLExecution {
* thread from
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r188650358
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala ---
@@ -90,13 +92,42 @@ object SQLExecution {
* thread from the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187841313
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala ---
@@ -90,13 +92,33 @@ object SQLExecution {
* thread from
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187833760
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala ---
@@ -90,13 +92,33 @@ object SQLExecution {
* thread from
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187787271
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -898,7 +898,6 @@ object SparkSession extends Logging {
* @since
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187787215
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala ---
@@ -68,16 +68,27 @@ object SQLExecution {
//
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187787208
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala ---
@@ -68,16 +68,27 @@ object SQLExecution {
//
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187787083
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/CreateJacksonParser.scala
---
@@ -78,17 +78,4 @@ private[sql] object
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187775593
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala ---
@@ -68,16 +68,27 @@ object SQLExecution {
//
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187707287
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -99,12 +99,7 @@ object
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187697424
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -99,12 +99,7 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187669455
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/ReadOnlySQLConf.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187651050
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/ReadOnlySQLConf.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187618769
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/ReadOnlySQLConf.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187611167
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -99,12 +99,7 @@ object
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/21299
[SPARK-24250][SQL] support accessing SQLConf inside tasks
## What changes were proposed in this pull request?
Previously in #20136 we decided to forbid tasks to access `SQLConf`,
19 matches
Mail list logo
