[GitHub] spark pull request #21312: [SPARK-24259][SQL] ArrayWriter for Arrow produces...

2018-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21312 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21312: [SPARK-24259][SQL] ArrayWriter for Arrow produces...

2018-05-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21312#discussion_r188196324 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala --- @@ -133,6 +133,14 @@ private[arrow] abstract class

[GitHub] spark pull request #21312: [SPARK-24259][SQL] ArrayWriter for Arrow produces...

2018-05-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21312#discussion_r188184724 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala --- @@ -133,6 +133,14 @@ private[arrow] abstract class

[GitHub] spark pull request #21312: [SPARK-24259][SQL] ArrayWriter for Arrow produces...

2018-05-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21312#discussion_r187787882 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala --- @@ -311,6 +311,7 @@ private[arrow] class ArrayWriter(

[GitHub] spark pull request #21312: [SPARK-24259][SQL] ArrayWriter for Arrow produces...

2018-05-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21312#discussion_r187787511 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala --- @@ -311,6 +311,7 @@ private[arrow] class ArrayWriter(

[GitHub] spark pull request #21312: [SPARK-24259][SQL] ArrayWriter for Arrow produces...

2018-05-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21312#discussion_r187787343 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowWriter.scala --- @@ -311,6 +311,7 @@ private[arrow] class ArrayWriter(

[GitHub] spark pull request #21312: [SPARK-24259][SQL] ArrayWriter for Arrow produces...

2018-05-12 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/21312 [SPARK-24259][SQL] ArrayWriter for Arrow produces wrong output ## What changes were proposed in this pull request? Right now `ArrayWriter` used to output Arrow data for array type, doesn't