Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r193936753
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,139 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r193933505
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,139 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r193933656
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala
---
@@ -0,0 +1,146 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r193934305
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotsStoreImpl.scala
---
@@ -0,0 +1,95
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r192271761
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user dvogelbacher commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r192200162
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user dvogelbacher commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r192191070
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user dvogelbacher commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r192187376
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user dvogelbacher commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r192197340
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,120 @@
Github user dvogelbacher commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r192187397
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user dvogelbacher commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r192182970
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,120 @@
Github user dvogelbacher commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r192189992
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191919610
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,120 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191918908
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
I don't think this
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191914872
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191914601
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsEventQueue.scala
---
@@ -0,0 +1,29 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191914114
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,120 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191913958
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +154,24 @@ private[spark] object Config
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191865387
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +154,24 @@ private[spark] object Config
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191868513
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsEventQueue.scala
---
@@ -0,0 +1,29 @@
+/*
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191866216
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,120 @@
+/*
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191869618
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191871593
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,120 @@
+/*
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191865834
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,120 @@
+/*
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191653358
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
right - not
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191559897
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
Is it necessary to
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191502285
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
> I think I'm a bit
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191061920
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191061883
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +154,24 @@ private[spark] object
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191061890
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +154,24 @@ private[spark] object
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191061877
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
I think I'm a bit
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191061934
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
also add
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191061892
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,120 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190973324
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -56,17 +56,43 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190973344
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -56,17 +56,43 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190967916
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingEventSource.scala
---
@@ -0,0
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190967170
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingEventSource.scala
---
@@ -0,0 +1,65
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190966224
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -56,17 +56,43
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190964855
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -56,17 +56,43 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190964894
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -56,17 +56,43 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190964856
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingEventSource.scala
---
@@ -0,0
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190964276
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingEventSource.scala
---
@@ -0,0 +1,65
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190964141
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -56,17 +56,43
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190963830
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190963140
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -56,17 +56,43 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190962726
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190958844
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -56,17 +56,43
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190952296
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsEventQueue.scala
---
@@ -0,0 +1,29 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190954413
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190956726
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -56,17 +56,43
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190952481
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsEventQueue.scala
---
@@ -0,0 +1,29 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190954775
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingEventSource.scala
---
@@ -0,0
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190953795
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190956385
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -56,17 +56,43
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r190951741
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +154,24 @@ private[spark] object
55 matches
Mail list logo