[GitHub] spark pull request #21379: [SPARK-24327][SQL] Add an option to quote a parti...

2018-06-14 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21379#discussion_r195315740 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala --- @@ -51,7 +53,11 @@ private[sql] object

[GitHub] spark pull request #21379: [SPARK-24327][SQL] Add an option to quote a parti...

2018-06-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21379#discussion_r195314034 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala --- @@ -78,7 +84,17 @@ private[sql] object

[GitHub] spark pull request #21379: [SPARK-24327][SQL] Add an option to quote a parti...

2018-06-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21379#discussion_r195313861 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala --- @@ -99,10 +115,21 @@ private[sql] object

[GitHub] spark pull request #21379: [SPARK-24327][SQL] Add an option to quote a parti...

2018-06-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21379#discussion_r195313934 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala --- @@ -51,7 +53,11 @@ private[sql] object

[GitHub] spark pull request #21379: [SPARK-24327][SQL] Add an option to quote a parti...

2018-06-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21379#discussion_r195313083 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala --- @@ -1206,4 +1211,47 @@ class JDBCSuite extends SparkFunSuite

[GitHub] spark pull request #21379: [SPARK-24327][SQL] Add an option to quote a parti...

2018-05-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21379#discussion_r191641304 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala --- @@ -78,7 +79,12 @@ private[sql] object

[GitHub] spark pull request #21379: [SPARK-24327][SQL] Add an option to quote a parti...

2018-05-27 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21379#discussion_r191117129 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala --- @@ -78,7 +79,12 @@ private[sql] object

[GitHub] spark pull request #21379: [SPARK-24327][SQL] Add an option to quote a parti...

2018-05-23 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21379#discussion_r190450621 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala --- @@ -78,7 +79,12 @@ private[sql] object

[GitHub] spark pull request #21379: [SPARK-24327][SQL] Add an option to quote a parti...

2018-05-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21379#discussion_r190382338 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala --- @@ -78,7 +79,12 @@ private[sql] object

[GitHub] spark pull request #21379: [SPARK-24327][SQL] Add an option to quote a parti...

2018-05-21 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21379#discussion_r189774838 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala --- @@ -78,7 +79,12 @@ private[sql] object

[GitHub] spark pull request #21379: [SPARK-24327][SQL] Add an option to quote a parti...

2018-05-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21379#discussion_r189718595 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala --- @@ -78,7 +79,12 @@ private[sql] object

[GitHub] spark pull request #21379: [SPARK-24327][SQL] Add an option to quote a parti...

2018-05-20 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/21379 [SPARK-24327][SQL] Add an option to quote a partition column name in JDBCRelation ## What changes were proposed in this pull request? This pr added a new option to quote a partition column name