Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21389
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198355457
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198355370
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198351604
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198350214
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198350225
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198348474
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite extends
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198342819
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198341944
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198341922
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198341823
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198341248
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,230 @@ class FileBasedDataSourceSuite
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r198340297
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r197626497
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r197626501
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,222 @@ class FileBasedDataSourceSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r197626306
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r197626232
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
@@ -202,4 +204,222 @@ class FileBasedDataSourceSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r197626168
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r197626164
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r197626154
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r197626122
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r195579915
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r195472992
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r190791115
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r190461717
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r190461628
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r190461517
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r190461402
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r190136535
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
---
@@ -89,6 +89,8 @@ class OrcFileFormat
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r190130347
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
---
@@ -89,6 +89,8 @@ class OrcFileFormat
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r189964737
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2408,4 +2409,53 @@ class JsonSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r189964186
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2408,4 +2409,53 @@ class JsonSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r189961194
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2408,4 +2409,53 @@ class JsonSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r189952391
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2408,4 +2409,53 @@ class JsonSuite extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r189924257
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonUtils.scala
---
@@ -48,4 +49,33 @@ object JsonUtils {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r189913422
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonUtils.scala
---
@@ -48,4 +49,33 @@ object JsonUtils {
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r189872259
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonUtils.scala
---
@@ -48,4 +49,33 @@ object JsonUtils {
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/21389
[SPARK-24204][SQL] Verify a schema in Json/Orc/ParquetFileFormat
## What changes were proposed in this pull request?
This pr added code to verify a schema in Json/Orc/ParquetFileFormat along
38 matches
Mail list logo
