[GitHub] spark pull request #21479: [SPARK-23903][SQL] Add support for date extract

2018-06-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21479 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21479: [SPARK-23903][SQL] Add support for date extract

2018-06-01 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21479#discussion_r192534591 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1206,6 +1206,41 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #21479: [SPARK-23903][SQL] Add support for date extract

2018-06-01 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21479#discussion_r192534446 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -739,6 +740,7 @@ nonReserved | VIEW | REPLACE

[GitHub] spark pull request #21479: [SPARK-23903][SQL] Add support for date extract

2018-06-01 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21479#discussion_r192534696 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1206,6 +1206,41 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #21479: [SPARK-23903][SQL] Add support for date extract

2018-06-01 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21479#discussion_r192516776 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -592,6 +592,7 @@ primaryExpression | identifier

[GitHub] spark pull request #21479: [SPARK-23903][SQL] Add support for date extract

2018-06-01 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/21479 [SPARK-23903][SQL] Add support for date extract ## What changes were proposed in this pull request? Add support for date `extract`, supported field same as