[GitHub] spark pull request #21486: [SPARK-24387][Core] Heartbeat-timeout executor is...

2018-06-11 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/21486#discussion_r194606075 --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala --- @@ -197,14 +197,14 @@ private[spark] class HeartbeatReceiver(sc: SparkContext,

[GitHub] spark pull request #21486: [SPARK-24387][Core] Heartbeat-timeout executor is...

2018-06-05 Thread lirui-apache
Github user lirui-apache commented on a diff in the pull request: https://github.com/apache/spark/pull/21486#discussion_r193044306 --- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala --- @@ -207,6 +210,54 @@ class HeartbeatReceiverSuite

[GitHub] spark pull request #21486: [SPARK-24387][Core] Heartbeat-timeout executor is...

2018-06-05 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21486#discussion_r192976073 --- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala --- @@ -207,6 +210,54 @@ class HeartbeatReceiverSuite

[GitHub] spark pull request #21486: [SPARK-24387][Core] Heartbeat-timeout executor is...

2018-06-03 Thread lirui-apache
Github user lirui-apache commented on a diff in the pull request: https://github.com/apache/spark/pull/21486#discussion_r192614888 --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala --- @@ -197,14 +197,14 @@ private[spark] class HeartbeatReceiver(sc:

[GitHub] spark pull request #21486: [SPARK-24387][Core] Heartbeat-timeout executor is...

2018-06-03 Thread lirui-apache
Github user lirui-apache commented on a diff in the pull request: https://github.com/apache/spark/pull/21486#discussion_r192614874 --- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala --- @@ -207,6 +210,55 @@ class HeartbeatReceiverSuite

[GitHub] spark pull request #21486: [SPARK-24387][Core] Heartbeat-timeout executor is...

2018-06-03 Thread lirui-apache
Github user lirui-apache commented on a diff in the pull request: https://github.com/apache/spark/pull/21486#discussion_r192614878 --- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala --- @@ -207,6 +210,55 @@ class HeartbeatReceiverSuite

[GitHub] spark pull request #21486: [SPARK-24387][Core] Heartbeat-timeout executor is...

2018-06-03 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/21486#discussion_r192592142 --- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala --- @@ -207,6 +210,55 @@ class HeartbeatReceiverSuite

[GitHub] spark pull request #21486: [SPARK-24387][Core] Heartbeat-timeout executor is...

2018-06-03 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/21486#discussion_r192592170 --- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala --- @@ -207,6 +210,55 @@ class HeartbeatReceiverSuite

[GitHub] spark pull request #21486: [SPARK-24387][Core] Heartbeat-timeout executor is...

2018-06-03 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/21486#discussion_r192591845 --- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala --- @@ -207,6 +210,55 @@ class HeartbeatReceiverSuite

[GitHub] spark pull request #21486: [SPARK-24387][Core] Heartbeat-timeout executor is...

2018-06-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21486#discussion_r192576961 --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala --- @@ -197,14 +197,14 @@ private[spark] class HeartbeatReceiver(sc:

[GitHub] spark pull request #21486: [SPARK-24387][Core] Heartbeat-timeout executor is...

2018-06-02 Thread lirui-apache
GitHub user lirui-apache opened a pull request: https://github.com/apache/spark/pull/21486 [SPARK-24387][Core] Heartbeat-timeout executor is added back and used again ## What changes were proposed in this pull request? When an executor's heartbeat is lost, we call