Github user ssonker closed the pull request at:
https://github.com/apache/spark/pull/21505
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r206741169
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/StringToTimestampBenchmark.scala
---
@@ -0,0 +1,53 @@
+/*
--- End diff --
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r206699663
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,22 @@ object DateTimeUtils {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r202548671
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/StringToTimestampBenchmark.scala
---
@@ -0,0 +1,53 @@
+/*
--- End diff --
Does
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194848108
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,22 @@ object DateTimeUtils {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194847824
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/StringToTimestampBenchmark.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194365155
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194325153
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils {
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194319491
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194309823
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils {
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194305723
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194299485
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194294961
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -125,7 +125,6 @@ object DateTimeUtils {
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194294182
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -125,7 +125,6 @@ object DateTimeUtils {
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194292883
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194268734
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193696451
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils {
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193694372
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193688565
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,23 @@ object DateTimeUtils {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193687670
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -114,20 +114,19 @@ object DateTimeUtils {
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193687346
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -114,20 +114,19 @@ object DateTimeUtils {
}
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193686772
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils {
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193679978
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193678440
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils {
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193676953
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193676413
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils {
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193675674
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils {
Github user ssonker commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193675439
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r193674578
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -111,6 +113,24 @@ object DateTimeUtils {
GitHub user ssonker opened a pull request:
https://github.com/apache/spark/pull/21505
[SPARK-24457][SQL] Improving performance of stringToTimestamp by cachâ¦
â¦ing Calendar instances for input timezones instead of creating new
everytime
## What changes were proposed in
30 matches
Mail list logo
