Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21542
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r200934983
--- Diff: pom.xml ---
@@ -2606,6 +2606,28 @@
+
+com.github.spotbugs
+
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r200926335
--- Diff: pom.xml ---
@@ -2606,6 +2606,28 @@
+
+com.github.spotbugs
+
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r200922589
--- Diff: pom.xml ---
@@ -2606,6 +2606,28 @@
+
+com.github.spotbugs
+
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r200867924
--- Diff: pom.xml ---
@@ -2606,6 +2606,28 @@
+
+com.github.spotbugs
+
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r200866847
--- Diff: pom.xml ---
@@ -2606,6 +2606,28 @@
+
+com.github.spotbugs
+
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r200193562
--- Diff: resource-managers/kubernetes/core/pom.xml ---
@@ -47,6 +47,12 @@
test
+
--- End diff --
This change
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r200043228
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala ---
@@ -368,8 +368,7 @@ private[spark] class ExternalSorter[K, V, C](
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r200037280
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala ---
@@ -368,8 +368,7 @@ private[spark] class ExternalSorter[K, V, C](
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r198339898
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -294,7 +294,8 @@ object CaseWhen {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r198338923
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala ---
@@ -369,7 +369,7 @@ private[spark] class ExternalSorter[K, V, C](
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r198232308
--- Diff: pom.xml ---
@@ -2606,6 +2606,35 @@
+
+com.github.spotbugs
+
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r197613977
--- Diff: pom.xml ---
@@ -2606,6 +2606,35 @@
+
+com.github.spotbugs
+
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r196140047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -522,7 +522,8 @@ trait ArraySortLike
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21542#discussion_r196084725
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -522,7 +522,8 @@ trait ArraySortLike
15 matches
Mail list logo
