[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195886078 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala --- @@ -70,7 +70,7 @@ case class ReusedExchangeExec(override val

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195883736 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -2270,4 +2270,15 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195883713 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -2270,4 +2270,15 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195654141 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -170,6 +170,8 @@ case class

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-15 Thread yucai
Github user yucai commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195652026 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -170,6 +170,8 @@ case class

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195630214 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -170,6 +170,8 @@ case class

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-14 Thread yucai
Github user yucai commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195463301 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -170,6 +170,8 @@ case class

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195420136 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -170,6 +170,8 @@ case class

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r19535 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -170,6 +170,8 @@ case class

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-14 Thread yucai
Github user yucai commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195361725 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -170,6 +170,8 @@ case class

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195356161 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -170,6 +170,8 @@ case class

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-14 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195355721 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -170,6 +170,8 @@ case class

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-14 Thread yucai
Github user yucai commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195354829 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -170,6 +170,8 @@ case class

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195352300 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -170,6 +170,8 @@ case class

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-14 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195349283 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -170,6 +170,8 @@ case class

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21564#discussion_r195348233 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala --- @@ -170,6 +170,8 @@ case class

[GitHub] spark pull request #21564: [SPARK-24556][SQL] ReusedExchange should rewrite ...

2018-06-14 Thread yucai
GitHub user yucai opened a pull request: https://github.com/apache/spark/pull/21564 [SPARK-24556][SQL] ReusedExchange should rewrite output partitioning also when child's partitioning is RangePartitioning ## What changes were proposed in this pull request? Currently,