Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21674
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21674#discussion_r199315202
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -149,6 +149,7 @@ package object dsl {
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21674#discussion_r199314983
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2792,4 +2792,25 @@ class SQLQuerySuite extends QueryTest with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21674#discussion_r199310542
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -149,6 +149,7 @@ package object dsl {
}
}
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21674#discussion_r199310515
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -149,6 +149,7 @@ package object dsl {
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21674#discussion_r199309806
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2792,4 +2792,25 @@ class SQLQuerySuite extends QueryTest with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21674#discussion_r199309687
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -149,6 +149,7 @@ package object dsl {
}
}
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21674
[SPARK-24696][SQL] ColumnPruning rule fails to remove extra Project
## What changes were proposed in this pull request?
The ColumnPruning rule tries adding an extra Project if an input
