[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21711 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21711#discussion_r202568645 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -138,17 +138,36 @@ private[spark] class

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21711#discussion_r202567965 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -138,17 +138,36 @@ private[spark] class

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21711#discussion_r202537869 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -138,17 +138,36 @@ private[spark] class

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21711#discussion_r202536743 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -138,17 +138,35 @@ private[spark] class

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21711#discussion_r202536673 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -2005,6 +2005,24 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21711#discussion_r202536655 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -138,17 +138,35 @@ private[spark] class

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21711#discussion_r202531134 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -138,17 +138,35 @@ private[spark] class

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21711#discussion_r202531122 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -138,17 +138,35 @@ private[spark] class

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21711#discussion_r202531090 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -2005,6 +2005,24 @@ class SQLQuerySuite extends

[GitHub] spark pull request #21711: [SPARK-24681][SQL] Verify nested column names in ...

GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/21711 [SPARK-24681][SQL] Verify nested column names in Hive metastore ## What changes were proposed in this pull request? This pr added code to check if nested column names do not include ',', ':',