[GitHub] spark pull request #21719: [SPARK-24747][ML] Make Instrumentation class more...

2018-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21719 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21719: [SPARK-24747][ML] Make Instrumentation class more...

2018-07-17 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/21719#discussion_r203126526 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala --- @@ -19,45 +19,60 @@ package org.apache.spark.ml.util import

[GitHub] spark pull request #21719: [SPARK-24747][ML] Make Instrumentation class more...

2018-07-16 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/21719#discussion_r202800969 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -488,9 +488,10 @@ class LogisticRegression

[GitHub] spark pull request #21719: [SPARK-24747][ML] Make Instrumentation class more...

2018-07-16 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/21719#discussion_r202805710 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala --- @@ -19,45 +19,60 @@ package org.apache.spark.ml.util import