[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21740 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-16 Thread dmateusp
Github user dmateusp commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202614320 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -165,7 +183,7 @@ class

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-15 Thread shahidki31
Github user shahidki31 commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202547781 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -75,11 +75,29 @@ class

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-15 Thread shahidki31
Github user shahidki31 commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202547705 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -75,11 +75,29 @@ class

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202545740 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -165,7 +183,7 @@ class MatrixFactorizationModel

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202545589 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -75,11 +75,29 @@ class MatrixFactorizationModel

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-15 Thread dmateusp
Github user dmateusp commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202542318 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -165,7 +183,7 @@ class

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-15 Thread shahidki31
Github user shahidki31 commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202534469 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -75,10 +75,22 @@ class

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-15 Thread shahidki31
Github user shahidki31 commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202534384 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModelSuite.scala --- @@ -72,6 +72,22 @@ class

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-14 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202531693 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala --- @@ -75,10 +75,22 @@ class MatrixFactorizationModel

[GitHub] spark pull request #21740: [SPARK-18230][MLLib]Throw a better exception, if ...

2018-07-14 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/21740#discussion_r202531686 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModelSuite.scala --- @@ -72,6 +72,22 @@ class