Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21804
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21804#discussion_r203947486
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala
---
@@ -104,7 +104,7 @@ class HashingTF @Since("1.4.0") (@Since("1.4.0")
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21804#discussion_r203947449
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala ---
@@ -208,8 +208,9 @@ class FeatureHasher(@Since("2.3.0") override val
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21804#discussion_r203746047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
---
@@ -145,7 +145,7 @@ abstract class NumericType extends
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21804#discussion_r203656238
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
---
@@ -145,7 +145,7 @@ abstract class NumericType extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21804#discussion_r203585703
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
---
@@ -145,7 +145,7 @@ abstract class NumericType extends
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/21804
[SPARK-24268][SQL] Use datatype.catalogString in error messages
## What changes were proposed in this pull request?
As stated in https://github.com/apache/spark/pull/21321, in the error
