Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21813
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203918259
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -442,17 +442,35 @@ class Analyzer(
child:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203918204
--- Diff: sql/core/src/test/resources/sql-tests/inputs/grouping_set.sql ---
@@ -13,5 +13,39 @@ SELECT a, b, c, count(d) FROM grouping GROUP BY a, b, c
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203917186
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -442,17 +442,35 @@ class Analyzer(
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203917039
--- Diff: sql/core/src/test/resources/sql-tests/inputs/grouping_set.sql ---
@@ -13,5 +13,39 @@ SELECT a, b, c, count(d) FROM grouping GROUP BY a, b, c
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203914517
--- Diff: sql/core/src/test/resources/sql-tests/inputs/grouping_set.sql ---
@@ -13,5 +13,39 @@ SELECT a, b, c, count(d) FROM grouping GROUP BY a, b, c
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203882365
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -442,17 +442,32 @@ class Analyzer(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203882021
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -442,17 +442,32 @@ class Analyzer(
child:
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203861013
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveGroupingAnalyticsSuite.scala
---
@@ -91,6 +91,40 @@ class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203859940
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -442,17 +442,32 @@ class Analyzer(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203842450
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveGroupingAnalyticsSuite.scala
---
@@ -91,6 +91,40 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203841560
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -442,17 +442,32 @@ class Analyzer(
child:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203813530
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -400,12 +400,12 @@ hintStatement
fromClause
:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203813381
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -440,19 +440,36 @@ class Analyzer(
14 matches
Mail list logo
