[GitHub] spark pull request #21840: [WIP] New copy() method for Column of StructType

2018-07-23 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/21840#discussion_r204476440 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -3858,3 +3858,29 @@ object ArrayUnion

[GitHub] spark pull request #21840: [WIP] New copy() method for Column of StructType

2018-07-22 Thread ssimeonov
Github user ssimeonov commented on a diff in the pull request: https://github.com/apache/spark/pull/21840#discussion_r204250360 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -1234,6 +1234,8 @@ class Column(val expr: Expression) extends Logging {

[GitHub] spark pull request #21840: [WIP] New copy() method for Column of StructType

2018-07-22 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21840#discussion_r204250231 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -1234,6 +1234,8 @@ class Column(val expr: Expression) extends Logging {

[GitHub] spark pull request #21840: [WIP] New copy() method for Column of StructType

2018-07-22 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21840#discussion_r204250170 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -3858,3 +3858,29 @@ object ArrayUnion {

[GitHub] spark pull request #21840: [WIP] New copy() method for Column of StructType

2018-07-22 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21840#discussion_r204249828 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -3858,3 +3858,29 @@ object ArrayUnion {