Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21860
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r229283365
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -854,33 +862,50 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r228434359
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -831,7 +832,14 @@ case class
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r227706394
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -831,7 +832,14 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r227655432
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -831,7 +832,14 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r227650326
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -831,7 +832,14 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r226981919
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -744,6 +744,7 @@ case class HashAggregateExec(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r215907441
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +861,50 @@ case class HashAggregateExec(
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r214625811
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +853,47 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r214584609
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +853,47 @@ case class HashAggregateExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r213547480
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +853,48 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r212857658
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +853,47 @@ case class HashAggregateExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r212854595
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +853,47 @@ case class HashAggregateExec(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r212549322
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +853,47 @@ case class HashAggregateExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r211994713
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +853,43 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r211994204
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +853,43 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r210158345
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -232,6 +232,25 @@ class WholeStageCodegenSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r210157862
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +853,42 @@ case class
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r210154989
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -232,6 +232,25 @@ class WholeStageCodegenSuite
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r210154851
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +853,42 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r208814871
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -853,33 +853,42 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r208788502
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -232,6 +232,25 @@ class WholeStageCodegenSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r207955873
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -232,6 +232,23 @@ class WholeStageCodegenSuite extends
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r207854432
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -232,6 +232,23 @@ class WholeStageCodegenSuite
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r207809333
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -232,6 +232,23 @@ class WholeStageCodegenSuite extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r207475539
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -232,6 +232,22 @@ class WholeStageCodegenSuite extends
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r205943335
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -232,6 +232,22 @@ class WholeStageCodegenSuite
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r205850895
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -232,6 +232,22 @@ class WholeStageCodegenSuite extends
GitHub user heary-cao opened a pull request:
https://github.com/apache/spark/pull/21860
[SPARK-24901][SQL]Merge the codegen of RegularHashMap and fastHashMap to
reduce compiler maxCodesize when VectorizedHashMap is false.
## What changes were proposed in this pull request?
29 matches
Mail list logo