[GitHub] spark pull request #21978: [SPARK-25006][SQL] Add CatalogTableIdentifier.

2018-11-29 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21978#discussion_r237660050 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala --- @@ -18,48 +18,106 @@ package org.apache.spark.sql.catalyst

[GitHub] spark pull request #21978: [SPARK-25006][SQL] Add CatalogTableIdentifier.

2018-11-29 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21978#discussion_r237656841 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala --- @@ -18,48 +18,106 @@ package org.apache.spark.sql.catalyst

[GitHub] spark pull request #21978: [SPARK-25006][SQL] Add CatalogTableIdentifier.

2018-11-29 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21978#discussion_r237585203 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala --- @@ -18,48 +18,106 @@ package org.apache.spark.sql.catalyst

[GitHub] spark pull request #21978: [SPARK-25006][SQL] Add CatalogTableIdentifier.

2018-11-29 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21978#discussion_r237578911 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala --- @@ -18,48 +18,106 @@ package org.apache.spark.sql.catalyst

[GitHub] spark pull request #21978: [SPARK-25006][SQL] Add CatalogTableIdentifier.

2018-11-29 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21978#discussion_r237578805 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala --- @@ -18,48 +18,106 @@ package org.apache.spark.sql.catalyst