[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r226780862 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala --- @@ -169,15 +174,16 @@ object

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r224023061 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala --- @@ -169,15 +174,16 @@ object

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r224004348 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala --- @@ -169,15 +174,16 @@ object

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r223988838 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala --- @@ -169,15 +174,16 @@ object

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r223982672 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala --- @@ -169,15 +174,16 @@ object

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22009 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r211808923 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousTest.scala --- @@ -47,7 +47,9 @@ trait KafkaContinuousTest

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r211739221 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousTest.scala --- @@ -47,7 +47,9 @@ trait

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r211692277 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/BatchReadSupportProvider.java --- @@ -18,48 +18,44 @@ package

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r211660836 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/BatchReadSupportProvider.java --- @@ -18,48 +18,44 @@ package

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r211644387 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateControlMicroBatchReadSupport.scala --- @@ -17,21 +17,15 @@

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r211639298 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/ContinuousReadSupport.java --- @@ -24,16 +24,17 @@ import

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r211628439 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReadSupport.scala --- @@ -47,70 +46,49 @@ import

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r210155543 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/BatchWriteSupportProvider.java --- @@ -21,33 +21,39 @@ import

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r210154588 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateControlMicroBatchReadSupport.scala --- @@ -0,0 +1,31 @@ +/*

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r210154101 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ReadSupport.java --- @@ -45,9 +45,6 @@ * Note that, this may not be a

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r210024440 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + * Licensed

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r210021990 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + * Licensed

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209998505 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateControlMicroBatchReadSupport.scala --- @@ -0,0 +1,31 @@ +/*

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209997335 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ReadSupport.java --- @@ -45,9 +45,6 @@ * Note that, this may not be a full

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209996219 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala --- @@ -76,41 +76,43 @@ object

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209944154 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209941689 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/BatchReadSupport.java --- @@ -0,0 +1,47 @@ +/* + * Licensed to the

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209823382 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala --- @@ -76,41 +76,43 @@ object

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209726516 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala --- @@ -76,41 +76,43 @@ object

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209712363 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/BatchWriteSupportProvider.java --- @@ -21,33 +21,39 @@ import

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209708483 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/BatchWriteSupportProvider.java --- @@ -21,33 +21,39 @@ import

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209702134 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209699841 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/SessionConfigSupport.java --- @@ -27,10 +27,10 @@ @InterfaceStability.Evolving

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209698964 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/BatchWriteSupportProvider.java --- @@ -21,33 +21,39 @@ import

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209697665 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + * Licensed

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209310622 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209301920 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209301833 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/SessionConfigSupport.java --- @@ -27,10 +27,10 @@ @InterfaceStability.Evolving

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209133225 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/SessionConfigSupport.java --- @@ -27,10 +27,10 @@ @InterfaceStability.Evolving

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209126618 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/BatchWriteSupportProvider.java --- @@ -21,33 +21,39 @@ import

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209123977 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209094853 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209094259 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + * Licensed

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209093885 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/MicroBatchReadSupport.java --- @@ -0,0 +1,49 @@ +/* + * Licensed

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209059908 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209044995 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/ContinuousPartitionReaderFactory.java --- @@ -0,0 +1,71 @@ +/* +

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209042787 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala --- @@ -39,52 +36,43 @@ case class

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209042604 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala --- @@ -51,18 +58,19 @@ class DataSourceRDD[T:

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209042348 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala --- @@ -51,18 +58,19 @@ class DataSourceRDD[T:

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209042148 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + * Licensed

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209041811 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + * Licensed

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209041367 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ScanConfig.java --- @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209041048 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/MicroBatchReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209040246 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/MicroBatchReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209039505 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/ContinuousReadSupport.java --- @@ -0,0 +1,79 @@ +/* + * Licensed

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209038600 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/MicroBatchReadSupport.java --- @@ -0,0 +1,49 @@ +/* + * Licensed

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209023367 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2.java --- @@ -23,8 +23,9 @@ * The base interface for data source v2.

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209022769 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/ContinuousReadSupportProvider.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208983568 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/ContinuousReadSupportProvider.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208984614 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2.java --- @@ -23,8 +23,9 @@ * The base interface for data source v2.

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208763503 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/SessionConfigSupport.java --- @@ -27,10 +27,10 @@ @InterfaceStability.Evolving

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208984707 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/MicroBatchReadSupportProvider.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209019530 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209022127 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/SessionConfigSupport.java --- @@ -27,10 +27,10 @@ @InterfaceStability.Evolving

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208986233 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/BatchReadSupport.java --- @@ -0,0 +1,47 @@ +/* + * Licensed to the

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208987767 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/InputPartition.java --- @@ -22,18 +22,16 @@ import

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209013149 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/PartitionReaderFactory.java --- @@ -0,0 +1,68 @@ +/* + * Licensed to

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209018297 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/ContinuousReadSupport.java --- @@ -0,0 +1,79 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208982830 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/BatchReadSupportProvider.java --- @@ -18,19 +18,22 @@ package

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209021329 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/streaming/StreamingDataWriterFactory.java --- @@ -0,0 +1,58 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r209020054 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/BatchWriteSupportProvider.java --- @@ -21,33 +21,39 @@ import

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208808788 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ReadSupport.java --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208808091 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala --- @@ -76,41 +76,43 @@ object

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208802631 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/BatchWriteSupportProvider.java --- @@ -21,33 +21,39 @@ import

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208693454 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/ContinuousReadSupport.java --- @@ -0,0 +1,79 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208690097 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala --- @@ -51,18 +58,19 @@ class DataSourceRDD[T:

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208685140 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/ContinuousPartitionReaderFactory.java --- @@ -0,0 +1,71 @@ +/*

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208684225 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/ContinuousPartitionReaderFactory.java --- @@ -0,0 +1,71 @@ +/*

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208680325 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReadSupport.scala --- @@ -162,23 +141,52 @@ case class

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208662724 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/StreamingWriteSupportProvider.java --- @@ -29,24 +28,24 @@ * provide data writing

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208661027 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala --- @@ -51,18 +58,19 @@ class DataSourceRDD[T:

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208660320 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala --- @@ -39,52 +36,43 @@ case class

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208642760 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/MicroBatchReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208642771 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/StreamingWriteSupportProvider.java --- @@ -29,24 +28,24 @@ * provide data writing

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208642275 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/StreamingWriteSupportProvider.java --- @@ -29,24 +28,24 @@ * provide data writing

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user jose-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208641014 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208638600 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala --- @@ -93,21 +81,17 @@ case class

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208638252 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala --- @@ -39,52 +36,43 @@ case class

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208637663 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala --- @@ -51,18 +58,19 @@ class DataSourceRDD[T:

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208636636 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala --- @@ -51,18 +58,19 @@ class DataSourceRDD[T:

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208635572 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/MicroBatchReadSupport.java --- @@ -0,0 +1,49 @@ +/* + * Licensed

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208635227 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/ContinuousReadSupport.java --- @@ -0,0 +1,72 @@ +/* + * Licensed

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208634657 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + * Licensed

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208544232 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala --- @@ -270,11 +269,11 @@ private[kafka010]

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208440273 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala --- @@ -93,21 +81,17 @@ case class

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208439973 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExec.scala --- @@ -39,52 +36,43 @@ case class

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208439720 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala --- @@ -51,18 +58,19 @@ class DataSourceRDD[T:

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208439490 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala --- @@ -51,18 +58,19 @@ class DataSourceRDD[T:

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208439150 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/StreamingReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208438912 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/MicroBatchReadSupport.java --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208438810 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/ContinuousReadSupport.java --- @@ -0,0 +1,72 @@ +/* + *

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208437853 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/PartitionReaderFactory.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208437780 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/StreamingWriteSupportProvider.java --- @@ -29,24 +28,24 @@ * provide data writing

[GitHub] spark pull request #22009: [SPARK-24882][SQL] improve data source v2 API

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22009#discussion_r208437319 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/BatchReadSupportProvider.java --- @@ -19,18 +19,18 @@ import

  1   2   >