[GitHub] spark pull request #22078: [SPARK-25085][SQL] Insert overwrite a non-partiti...

2018-08-14 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22078#discussion_r209957030 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -626,6 +626,14 @@ object SQLConf { .stringConf .

[GitHub] spark pull request #22078: [SPARK-25085][SQL] Insert overwrite a non-partiti...

2018-08-14 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22078#discussion_r209954635 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -626,6 +626,14 @@ object SQLConf { .stringConf .c

[GitHub] spark pull request #22078: [SPARK-25085][SQL] Insert overwrite a non-partiti...

2018-08-14 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22078#discussion_r209940807 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala --- @@ -261,4 +273,67 @@ case class I

[GitHub] spark pull request #22078: [SPARK-25085][SQL] Insert overwrite a non-partiti...

2018-08-14 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22078#discussion_r209934062 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala --- @@ -261,4 +273,67 @@ case class In

[GitHub] spark pull request #22078: [SPARK-25085][SQL] Insert overwrite a non-partiti...

2018-08-14 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22078#discussion_r209859205 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala --- @@ -261,4 +273,67 @@ case class I

[GitHub] spark pull request #22078: [SPARK-25085][SQL] Insert overwrite a non-partiti...

2018-08-14 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22078#discussion_r209859644 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -626,6 +626,14 @@ object SQLConf { .stringConf .

[GitHub] spark pull request #22078: [SPARK-25085][SQL] Insert overwrite a non-partiti...

2018-08-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22078#discussion_r209430770 --- Diff: core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala --- @@ -124,6 +124,25 @@ abstract class FileCommitProtocol { f

[GitHub] spark pull request #22078: [SPARK-25085][SQL] Insert overwrite a non-partiti...

2018-08-11 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/22078 [SPARK-25085][SQL] Insert overwrite a non-partitioned table should not delete table folder ## What changes were proposed in this pull request? Insert overwrite a `non-partitioned` table sh