[GitHub] spark pull request #22078: [SPARK-25085][SQL] Table subdirectories should in...

2018-10-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22078#discussion_r228882841 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -626,6 +626,14 @@ object SQLConf { .stringConf

[GitHub] spark pull request #22078: [SPARK-25085][SQL] Table subdirectories should in...

2018-10-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22078#discussion_r228881996 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala --- @@ -70,7 +76,6 @@ case class

[GitHub] spark pull request #22078: [SPARK-25085][SQL] Table subdirectories should in...

2018-10-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22078#discussion_r228881824 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoHadoopFsRelationCommand.scala --- @@ -261,4 +272,69 @@ case

[GitHub] spark pull request #22078: [SPARK-25085][SQL] Table subdirectories should in...

2018-10-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22078#discussion_r226875401 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -257,7 +257,102 @@ class HiveCatalogedDDLSuite